Prefer local ScalaModuleInfo over global config#609
Merged
eed3si9n merged 2 commits intocoursier:mainfrom Apr 5, 2026
Merged
Conversation
Regardless of configuration, all tests insist on forcing the download of scala library and at the same version.
Contributor
Author
kitbellew
force-pushed
the
sbt-scalafmt-433
branch
2 times, most recently
from
44ef8a7 to
3e8efa8
Compare
Collaborator
|
Looks like we need to either adjust the scripted tests or remove these ones: |
Otherwise, a user will never be able to download scala library at any other version.
kitbellew
force-pushed
the
sbt-scalafmt-433
branch
from
3e8efa8 to
68c31cf
Compare
Contributor
Author
I realized that I don't know what's happening here, and simply removed one line that I copied from the sbt implementation (setting org on coursier params), but added a |
kitbellew
added a commit
to kitbellew/sbt-scalafmt
that referenced
this pull request
Apr 8, 2026
That version fixes ability to download scala-library at given version, rather than the scala version of the build. See sbt/sbt#9028 (2.x) and coursier/sbt-coursier#609 (1.x).
kitbellew
added a commit
to scalameta/sbt-scalafmt
that referenced
this pull request
Apr 10, 2026
That version fixes ability to download scala-library at given version, rather than the scala version of the build. See sbt/sbt#9028 (2.x) and coursier/sbt-coursier#609 (1.x).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, a user will never be able to download scala library at any other version.
Helps with scalameta/sbt-scalafmt#433.